dip/service-catalog
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

feat: support inline tag in image.repository for jupyterlab chart

Browse Source 
Allow repository field to include a tag (e.g. "repo:tag"), in which case
the tag field is ignored. Update docs and custom-values to reflect the
new behavior and add dshm volume notes.
This commit is contained in:
ychangkim
2026-03-31 12:29:23 +09:00
parent b4213e4872
commit 9be83c6f3a
6 changed files with 55 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
manifests/helm/jupyterlab/1.0.0/templates/_helpers.tpl
+19 -3
View File
@@ -54,13 +54,29 @@ helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version }}
{{- end }}
{{/*
Full image reference: [registry/]repository:tag
Full image reference: [registry/]repository[:tag]
If repository already contains a tag (e.g. "repo:tag"), tag field is ignored.
*/}}
{{- define "jupyterlab.image" -}}
{{- $repo := .Values.image.repository }}
{{- $tag := .Values.image.tag }}
{{- $hasTag := contains ":" $repo }}
{{- if .Values.image.registry }}
{{- printf "%s/%s:%s" .Values.image.registry .Values.image.repository .Values.image.tag }}
{{- if $hasTag }}
{{- printf "%s/%s" .Values.image.registry $repo }}
{{- else if $tag }}
{{- printf "%s/%s:%s" .Values.image.registry $repo $tag }}
{{- else }}
{{- printf "%s:%s" .Values.image.repository .Values.image.tag }}
{{- printf "%s/%s" .Values.image.registry $repo }}
{{- end }}
{{- else }}
{{- if $hasTag }}
{{- $repo }}
{{- else if $tag }}
{{- printf "%s:%s" $repo $tag }}
{{- else }}
{{- $repo }}
{{- end }}
{{- end }}
{{- end }}